Fix clang warnings

diff --git a/client.cpp b/client.cpp
index c34bda652e6890aff3efd6793792cecf915b2849..9d7cf1c8b3e8cb9cf9dc3af9f97adf7fb291e81e 100644 (file)
--- a/client.cpp
+++ b/client.cpp
@@ -1219,7 +1219,7 @@ Client *Client::m_instance = 0;
 const int Client::UDP_API_COMMAND_TIMEOUT;
 #endif
 
-ANIDBUDPCLIENTSHARED_EXPORT char *revision()
+ANIDBUDPCLIENTSHARED_EXPORT const char *revision()
 {
 #ifdef REVISION
 #define ANI_GET_REV_I(X) #X

diff --git a/client.h b/client.h
index a2e1d628bd4c25f7f212f19a31c300b9316a7245..417c52c44e902b650b9902b99d23e9700f9f4c52 100644 (file)
--- a/client.h
+++ b/client.h
@@ -237,7 +237,7 @@ private:
        QHistoryState *connectedHistoryState;
 };
 
-ANIDBUDPCLIENTSHARED_EXPORT char *revision();
+ANIDBUDPCLIENTSHARED_EXPORT const char *revision();
 
 } // namespace AniDBUdpClient
 

diff --git a/filecommand.cpp b/filecommand.cpp
index 4b6e8887818dcd36e745cbcdf7ab2ddf29b6b3f5..5d2830b0889074de4cc9911e187209086037d95c 100644 (file)
--- a/filecommand.cpp
+++ b/filecommand.cpp
@@ -176,7 +176,7 @@ bool FileCommand::waitForResult() const
 
 bool FileCommand::isValid() const
 {
-       const bool validAnameGE = !m_aname.isEmpty() && (!m_gname.isEmpty() && m_epno || m_gid && m_epno);
+       const bool validAnameGE = !m_aname.isEmpty() && ((!m_gname.isEmpty() && m_epno) || (m_gid && m_epno));
        const bool validAidGE = m_aid && ((!m_gname.isEmpty() && m_epno) || (m_gid && m_epno));
        return (m_fid || (!m_ed2k.isEmpty() && m_size) || validAnameGE || validAidGE);
        // fmask & amask don't need to be checked as all invalid bits are removed

diff --git a/votecommand.cpp b/votecommand.cpp
index 349c933b535c4aa76a9797fbade524032a01b7e3..9921524c84b1692014a8d1f3223b75d130dbd17f 100644 (file)
--- a/votecommand.cpp
+++ b/votecommand.cpp
@@ -126,7 +126,7 @@ bool VoteCommand::waitForResult() const
 bool VoteCommand::isValid() const
 {
        return (m_id || !m_name.isEmpty())
-                       && (m_epno && m_voteType == AnimeVote || !m_epno);
+                       && ((m_epno && m_voteType == AnimeVote) || !m_epno);
        // Value is set to 0 if not in valid range
 }